Plese some more people start playing in the ladder! :)

[kozak6]

I'd join in if there were any point in doing so.

[tChr]

I'd join in if there were any point in doing so.

Wy isnt there? There should be at least 3 US servers now.

[KadaverJack]

Code: Select all

function pointRangeOk ($session_id, $enemy_id) {
   global £prefix, $conn, $pointrange;
   if ((get_playerpoints($enemy_id) - get_playerpoints($session_id)) <= $pointrange)  return true;
   return false;
}


I see bloat there!
I would suggest:

Code: Select all

function pointRangeOk ($session_id, $enemy_id) {
   global $prefix, $conn, $pointrange;
   return (get_playerpoints($enemy_id) - get_playerpoints($session_id)) <= $pointrange;
}

[tChr]

Code: Select all

function pointRangeOk ($session_id, $enemy_id) {
   global £prefix, $conn, $pointrange;
   if ((get_playerpoints($enemy_id) - get_playerpoints($session_id)) <= $pointrange)  return true;
   return false;
}


I see bloat there!
I would suggest:

Code: Select all

function pointRangeOk ($session_id, $enemy_id) {
   global $prefix, $conn, $pointrange;
   return (get_playerpoints($enemy_id) - get_playerpoints($session_id)) <= $pointrange;
}

Hmm,.. you're right
allthough:

Code: Select all

function pointRangeOk ($session_id, $enemy_id, $pointrange) {
   return (get_playerpoints($enemy_id) - get_playerpoints($session_id)) <= $pointrange;
}

Is even better
Then again.. why put it in a function.. unless you use it more than one place, that is
Edit: but still Greens way is a bit easier to debug

[GreEn`mArine]

I know that this if {} else {} thing is actually not needed in the function but I like it anyway ("return xx" would break the function anyway)

as this pointranke function IS used several times (not only for displaying the link but also for checking, whether the user is allowed to see the "Challenge" page, it is the easiest thing to have it in a function and not in every php page

[tChr]

I dont thek anyone means to critizise your code IWe just like to make a mindfuck of about everythign