Community made patches and improvements

[divVerent]

+ if(!scoreboard_active && !ons_showmap)
+ R_SetView(VF_DRAWCROSSHAIR, 0); //Make sure engine crosshairs are always hidden

Just remove that if check, to REALLY make sure

[MirceaKitsune]

Fixed. Updated links in my above post.

[esteel]

I still dislike the crosshair_default stuff

[MirceaKitsune]

I still dislike the crosshair_default stuff

Yeah, the word default didn't describe what that cvar was pretty well so I renamed them to crosshair_normal instead. A separate crosshair for the non-custom setting does need to exist however, as just using the last crosshair when disabling weapon customs would make things look ugly and broken I believe. It's much better to have a fixed crosshair to jump back to when disabling the custom weapon ones.

[esteel]

Did you see my other post? The _default or _normal stuff for the crosshair seems to be totally unneccessary to me as i have written above ( http://forums.alientrap.local/viewtopic.php?p=52190#52190 ). And i do not understand the problem you tried to just explain. Why would it show the last used CH and not the default one?

[MirceaKitsune]

Did you see my other post? The _default or _normal stuff for the crosshair seems to be totally unneccessary to me as i have written above. And i do not understand the problem you tried to just explain. Why would it show the last used CH and not the default one?

Div wants to move the entire crosshair rendering system csqc side as he said, so it would be impossible to disable custom weapon crosshairs without having a crosshair_default or crosshair_normal set as well, because the non-weapon-based crosshair wouldn't have how to get stored any more (the previous crosshair, crosshair_color_* etc. set of cvars were for the engine crosshairs, which will likely go out of usage now).

[esteel]

Those variables are defined in the engine, and the engine is not only used for Nexuiz.. so the non-csqc crosshair drawing will never be ripped out. So those variables will always be either at their defaults, or if someone changes them they get saved to config.cfg.. I think i was just a bit unclear or had a misunderstanding

[MirceaKitsune]

We could have the engine still drawing the non-custom crosshair and drawpic() only drawing the weapon based ones, so the darkplaces crosshairs won't remain unused in Nexuiz. It doesn't make much of a difference in-game so either is good, although I'm not sure if there is a purpose to complicate things with that so whatever everyone decides. I'll wait to see what Div says about this so I don't make something then revert it back if more devs believe it's better not being like that, but if that gets decided sure

[esteel]

I never said to use both ways to draw crosshairs... Just that we should use the currently existing VARIABLES of the engine to draw the default crosshair from CSQC (and only CSQC). As i see absolutly no benefit from using new variables for this. I however see the benefit that with doing so the users old settings would still be honored and that it would not require your changes to the menu.. I even gave you code that would just do that (its untested though and just typed away)

[MirceaKitsune]

I never said to use both ways to draw crosshairs... Just that we should use the currently existing VARIABLES of the engine to draw the default crosshair from CSQC (and only CSQC). As i see absolutly no benefit from using new variables for this. I however see the benefit that with doing so the users old settings would still be honored and that it would not require your changes to the menu.. I even gave you code that would just do that (its untested though and just typed away)

Aaah I see what you meant now, sorry. Sure, that could be done so the previous cvars are used for the default. Was going to fix that myself now but if you have my patch tuned to work like that feel free to apply it or repost here. Make sure it's based on my latest version of it so nothing else gets lots though, v5.6. Also the menu modification adding the "Custom weapon crosshairs" checkbox to the menu is a menu change independent of this so do keep that one with all the setDependents as well.