Community made patches and improvements

[terencehill]

very nice thing!

A suggestion:
use the same quad colors for numbers and logos. Red for shield, blue for strength.

Ah btw... these are the cvars to configure it:
sbar_strengthtimer_right 1
sbar_strengthtimer_pos 180

Another suggestion:
merge those cvars in one to semplify, leave only sbar_strengthtimer
Values can be: 1 2 3 4 5 6, first 3 values for right top, middle, bottom, last 3 for left top, middle, bottom
Oh... and 0 to disable it

[GreEn`mArine]

Hmm, I'm not sure whether the selection of top/middle/bottom is enough. I think that the configuration should go into the detailed pixel settings, because of other HUD elements that are already there (or new ones that might come up in the future) need to get along...

The coloring suggestion is a good suggestion though, and should be easy to add.

[MirceaKitsune]

I've created a strength / invincibility (Shield) timer that shows you how many seconds of your powerup are left. It is also shown if you spec a player who has it.

Can show strength and invinciblity pickup at the same time.

Position (left or right, and px from top border) is configurable

Good and useful patch, I hope it will be in. I strongly agree with terencehill though, the indicators need to be colored to the colors of the powerup (just the logos, I think the fonts look better white). Strength needs to be blue and invincibility red, I suggest you just color them in the code from the drawpic() color vectors.

Anyway, any news on the bloodloss mutator as well? Do I need to make any changes to it or is the feature rejected?

[terencehill]

Small improvement to the player's list, thanks to my patch, now players are showed with their own nick colors and with the scores that also tell the team through the color. I think it's better now IMO.
Download the patch here: http://sites.google.com/site/terencehill/Nexuiz/playerlist.patch

this is how it looks in the current SVN:


this is how it looks with this patch:

[GreEn`mArine]

@terencehill: I agree with that menu patch, does look better! And you know the scores

[divVerent]

The patches are not rejected, they're just too many for me and I have no time for this. Improve your patches the way you seem fit.

Short comments:

- bloodloss mutator is stupid. Sure, could integrate it, but I have absolutely no motivation to do so, as this is Nexuiz and not Counterstrike. Maybe someone else is interested in doing it.
- strength timer display: sure, why not. I just hope it isn't done in any stupid way, like, using a TE_CSQC_ message (these break savegames). It really must be either a stat or a shared entity. In any case, it should not send an update every second, but network the strength_finished time. Haven't looked at the code. As for the colors, I agree, strength should be blue, shield should be red. It should integrate with the current HUD (like, near the map timer), and NOT be freely positionable. It makes no sense to be able to freely position one item but not the others, but having cvars for this makes it harder to do future HUD changes that change the positions of other stuff (as people would get overlaps then, until they delete the cvar from their config.cfg).
- player color stuff: sure, could do that. See no real use of it, but well, that patch at least should be guaranteed to break nothing.

No idea if I missed any patch with this. This REALLY should be the task of someone else, though.

[divVerent]

Now looked at the bloodloss code.

First of all, this isn't a patch, but a broken something. Use a pastebin that does not turn patches into broken somethings, like http://paste.debian.net/

Secondly, the patch is broken. Change this line:

55. - if (self.BUTTON_CROUCH && !self.hook.state)
56. + if (self.BUTTON_CROUCH || self.health <= g_bloodloss && !self.hook.state)

to:

56. + if ((self.BUTTON_CROUCH && !self.hook.state) || self.health <= g_bloodloss)

as the crouch key has a special meaning while using the hook (it doesn't crouch the player, it just stops the pulling of the hook) and you broke it with your change.

[MirceaKitsune]

Changed that line as you asked, didn't realize that. Updated patch FILE and DEBIAN PASTE. The feature has a use for those who want it I think, I always found it an interesting mod even for Nexuiz-like games. It also adds a touch of strategic fighting as well since you now need to run for health packs as well during fighting in order to survive in extreme situations, and it also makes gameplay more intense at times.

Imho if I may say, I think anyone with SVN committing powers can take a look at these patches if they can judge them correctly. All that's needed I think is checking if they don't brake anything, and if they have a use and work correctly just commit them.

[divVerent]

Applied, although I still think this mutator absolutely doesn't fit with Nexuiz (which does the exact OPPOSITE: health REGENERATION).

BTW, all this pastebin and mediafire stuff should be replaced by a website where everyone can post his patches, and UPDATE THEM. As for green's ready restart timer thing, I am not even sure where to get the CURRENT version.

Maybe use the sourceforge feature request tracker for that in the future? Just an idea. I'll see what else SF has to offer for this.

https://sourceforge.net/tracker/?group_ ... tid=563409 - here it is. Please everyone upload patches THERE in the future, and update his post if he updates the patch.

[terencehill]

About this topic:
This topic is just a mess with patches posted in the middle of the comments of other patches...
I think this topic should be converted in a section "Community made patches and improvements" with a topic for each patch posted. When a patch is committed in the SVN, in the title it should be written "[committed]". You see that this way it's more organized and less confusing.

I posted here last patch I did of the player's list because it's a very small patch, but I was reluctant, whether do a new topic or not.

https://sourceforge.net/tracker/?group_id=81584&atid=563409 - here it is. Please everyone upload patches THERE in the future, and update his post if he updates the patch.

I suppose we should register on SourceForge to do that... not a problem.
Maybe using SF it's a similar solution to mine I talked above, but it lacks in 1 point: forum users will not go there to read new patches, to write whether they like or not our patch. Unless we post a link in the forum... don't know... maybe it's not so important this point.