[Committed]Weapon Accuracy Stats Patch

Developer discussion of experimental fixes, changes, and improvements.

Moderators: Nexuiz Moderators, Moderators

Postby divVerent » Sat Dec 27, 2008 2:55 pm

patch: **** malformed patch at line 433: float tempdb;

The patch is indeed broken. Looks like that pastebin site inserts empty lines somewhere. Try using a different site, like paste.debian.net.
1. Open Notepad
2. Paste: ÿþMSMSMS
3. Save
4. Open the file in Notepad again

You can vary the number of "MS", so you can clearly see it's MS which is causing it.
divVerent
Site admin and keyboard killer
 
Posts: 3809
Joined: Thu Mar 02, 2006 4:46 pm
Location: BRLOGENSHFEGLE

Postby Alien » Sat Dec 27, 2008 4:03 pm

I think svn has an ability to supress empty lines. Need to check again though.
Alien
Forum addon
 
Posts: 1212
Joined: Tue Apr 22, 2008 7:12 am

Postby divVerent » Sat Dec 27, 2008 6:09 pm

This is a syntactically broken diff file, not a bug/feature in svn. I am sure that pastebin did it.
1. Open Notepad
2. Paste: ÿþMSMSMS
3. Save
4. Open the file in Notepad again

You can vary the number of "MS", so you can clearly see it's MS which is causing it.
divVerent
Site admin and keyboard killer
 
Posts: 3809
Joined: Thu Mar 02, 2006 4:46 pm
Location: BRLOGENSHFEGLE

Postby Icarus » Sat Dec 27, 2008 6:34 pm

Doesnt matter if svn fixes it or not. That diff that i posted is broken. for some reason i cant get a proper diff with all the file changes
Icarus
 

Postby divVerent » Sat Dec 27, 2008 6:37 pm

How are you making the diff anyway?
1. Open Notepad
2. Paste: ÿþMSMSMS
3. Save
4. Open the file in Notepad again

You can vary the number of "MS", so you can clearly see it's MS which is causing it.
divVerent
Site admin and keyboard killer
 
Posts: 3809
Joined: Thu Mar 02, 2006 4:46 pm
Location: BRLOGENSHFEGLE

Postby Icarus » Sat Dec 27, 2008 11:14 pm

by doing svn diff < patch.diff
Icarus
 

Postby Alien » Sun Dec 28, 2008 4:46 pm

Code: Select all
svn diff -u > mypatch.diff
Alien
Forum addon
 
Posts: 1212
Joined: Tue Apr 22, 2008 7:12 am

Postby Icarus » Sun Dec 28, 2008 5:58 pm

what does -u do?
Icarus
 

Postby Alien » Sun Dec 28, 2008 7:55 pm

Shows -3,+3 lines (by default) above,below the patched place. Makes it easier to identify which places were changed.
Alien
Forum addon
 
Posts: 1212
Joined: Tue Apr 22, 2008 7:12 am

Postby [-z-] » Fri Jan 02, 2009 5:11 am

I got it working on my machine and created a patch

http://z.nexuizninjaz.com/mods/hitscanstats_r5311.patch

can someone test?


Edit: mkzelda and I both get:

patch: **** malformed patch at line 447: @@ -292,6 +294,14 @@
[-z-]
Site Admin and Nexuiz Ninja
 
Posts: 1794
Joined: Mon Nov 13, 2006 12:20 am
Location: Florida

PreviousNext

Return to Nexuiz - Development

Who is online

Users browsing this forum: No registered users and 1 guest

cron