Nexuiz startup vs network stability

[divVerent]

Against, as NetRadiant aims to be mostly code compatible with GtkRadiant, as long as there are other GtkRadiant forks out there that may have features NetRadiant could use.

If I did a batch change to change all these ifdefs, patches will be unlikely to still apply.

What I can do is add robustness by adding -DWIN32 to the compiler command line when building a Win32 build.

Actually, I just checked: the Makefile, which is an 1:1 port of the previous SCons based build system, always adds -DWIN32 when doing a Windows build. So in NetRadiant, this is just fine. Anyone adding a Visual Studio project has to read the Makefile anyway, as NetRadiant consists of lots of subprojects that need different compile settings (e.g. because there are multiple header files of the same name). I know it's ugly, but it matches what Id Software released as GtkRadiant and I'm not going to change that as long as there are other merge-worthy Radiant forks like DarkRadiant.

BTW, I just merged NetRadiant's q3map2 with VorteX's changes to the Urban Terror map compiler fork.

[tundramagi]

BTW, I just merged NetRadiant's q3map2 with VorteX's changes to the Urban Terror map compiler fork.

What new goodies does that bring ?

[Alien]

Should have I expected more?

Code: Select all

libs\math\vector.h(98) : fatal error C1001: An internal error has occurred in the compiler.
1>(compiler file 'msc1.cpp', line 1411)
1> To work around this problem, try simplifying or changing the program near the locations listed above.
1>Please choose the Technical Support command on the Visual C++
1> Help menu, or open the Technical Support help file for more information

Btw,

Code: Select all

#ifndef boolean
#ifdef __cplusplus
#define   boolean   bool
#else
#define boolean int
#endif
#endif

should be after

Code: Select all

#ifdef _WIN32
#include "windows.h"
#include "stdio.h"
#endif

in radiant_jpeglib.h otherwise it overrides internal windows header boolean definitions.

[divVerent]

That file is unmodified from idsoftware's

And what does it override? How does windows.h define boolean?

If windows.h does define boolean, I rather suggest that this block should be skipped instead. So I moved the windows.h include more up. Please test.

[Alien]

It's rpcndr.h which:

Code: Select all

typedef unsigned char boolean;

Then we get this error: http://msdn.microsoft.com/en-us/library/ws579tt7(VS.80).aspx

IdSoftware used(-s) STLPort instead.

[divVerent]

STLPort instead of what?

Why can't you just use STLPort too?

[Alien]

They use stlport in zeroradiant (it was required last time i compiled it) instead of relying of correct microsoft stl implementation.

[Alien]

Tested your commit. jpeg6 now builds correctly.