Disconnect does not stop map download

[Ed]

If you are connecting to a server and it's downloading a map, then try to disconnect it won't. stop the download. It will only stop the download on quitting Nexuiz. Should it be changed to on disconnect?

[divVerent]

Currently, the download can be only stopped using "curl --cancel". Note that while downloading, you are NOT connected to the server. If while downloading you connect to another server, the download still continues, but you can play on the other server - but when the download then finishes, it will NOT connect to the server requiring the download any more because you then are "already playing". Making disconnect also stop downloads would not allow this any more.

However, what about an alias? I could add an alias like disconnect_http or disconnect_downloads so you can find it by typing disconnect and Tab. Any idea how to call that one?

[Dokujisan]

I would imagine that people might want to change servers because there is a slow download and they are impatient. So I would suggest that the download be "attached" to the Nexuiz server where if they disconnect from the server, the download stops.

Maybe it could be an option for those who want to allow downloads to continue?

[KadaverJack]

Maybe it could be an option for those who want to allow downloads to continue?

No, there can't. 2.1 disconnects from the server while downloading, so if disconnect cancels downloads, you wouldn't be able to download anything.

[Ed]

What is needed then is two disconnect commands. The disconnect command that the user uses should disconnect from everything, including downloads. The disconnect that the downloader issues should not disconnect from downloads. This requires an engine change but it probably is the most logical thing to do. Otherwise you've got people disconnecting from a download but the download keeps going while they connect to another game, slowing gameplay down and possibly making them disconnect from another download as that one seems to be slow and so they try and connect to another server and another slow download runs so after a while they've got 10 slow downloads running all to different servers and the player is wondering where all of their bandwidth is going.

[divVerent]

1. Only one download is run at once...

2. Why does that need an engine change? I could easily add an alias that calls both disconnect and stops the download. All I need is a good name for it...

[Ed]

1. Only one download is run at once...

Good.

2. Why does that need an engine change? I could easily add an alias that calls both disconnect and stops the download. All I need is a good name for it...

That would be the wrong way round. When the user types disconnect they really mean disconnect from everything. The engine would need changing so that the disconnect command does disconnect downloads too and that the map download function does not call disconnect but instead calls a function that only disconnects from the map, rather than from the download. So we'd have:

Disconnect: functions as currently but also disconnects from downloads. This is more logical.

disconnect_keepdownloads: does what the current disconnect does. This is what the download function would call.

This would be better than a disconnect_downloads alias which does what most people would expect disconnect to do. That would be illogical.

That's why an engine change is needed as it's a change in the way the disconnect works and IMHO it is the logical way to do it. Something for the DP devs to think about.

[divVerent]

Well, it was an intended feature that downloads can run in the background and get queued. That was the reason why bandwidth limiting got implemented.

A cool idea could be initiating the next download while playing but before the game ends, so you already have the map you need for the next game and don't need to wait at all. If mapcfg and bsp names would correlate and QC had some string manipulation functions, we could implement that - probably for Nexuiz 3.

And the reason why disconnect does NOT cancel the download is simple - next time you need the map, it is better if you then actually have it. And downloads can be independent from map changes. Servers could for example offer a way for you to request data from them, like ALL the maps they have (not implemented yet, but not hard to do even for someone who can't code much).