Problem with new cvar parsing in svn

[animus]

As of svn r7466/7467, the following binds that I have no longer work properly. The toggle is fine, but displaying the value of the cvar is problematic. If I paste the binds below into config.cfg, they work as expected -- but only the first time I launch Nexuiz. The $$r_novis becomes $r_novis after the first run, then it becomes the last value for that cvar after the second. I also tried ${$r_novis} without success: Nexuiz displays "Could not expand $$r_novis".

bind h "toggle r_shadow_realtime_world; echo Realtime World Lighting: $$r_shadow_realtime_world"
bind j "toggle r_novis; echo r_noVis: $$r_novis"

[divVerent]

Yes, LordHavoc wanted alias to have a special exception that no cvar expansion takes place in its arguments - then the same should go for bind and in_bind, IMHO.

Code: Select all

set x 3

bind FOO "echo $x"
// will echo the value of $x when FOO is pressed

"bind" FOO "echo $x"
// will echo 3 when FOO is pressed


Done.

Also, backslashes and quotes are now saved correctly.

[Blµb]

Yes, LordHavoc wanted alias to have a special exception that no cvar expansion takes place in its arguments - then the same should go for bind and in_bind, IMHO.

Code: Select all

set x 3

bind FOO "echo $x"
// will echo the value of $x when FOO is pressed

"bind" FOO "echo $x"
// will echo 3 when FOO is pressed


Done.

Also, backslashes and quotes are now saved correctly.

So, do backslashes work for quotes only, or can I use
"bind" FOO "echo \$x"
to work like
bind FOO "echo $x"

[animus]

Alright, these now work as expected. Thanks.

bind h "toggle r_shadow_realtime_world; echo Realtime World Lighting: $r_shadow_realtime_world"
bind j "toggle r_novis; echo r_noVis: $r_novis"

[divVerent]

Backslash doesn't quote $, but $ does: $$ is a quoted $.

[Blµb]

then there's no way to have
bind x display_var "echo $$varname"

display the var defined in varname? so I toggle through a bunch of varnames, setting $varname to their name, and have $$varname display it?
like
set varname fov;
then x displays fov?

[divVerent]

bind x "echo ${$varname}"

Indirection, which previously was possible unintendedly in alias+cvar expansion (because they were two separate steps), was reintroduced as an intentional feature.

[AceOfThumbs]

Indirection isn't working in 2.3 on Macs or in 2.4 on Linux. Here's an example:
set x 1
set i x
echo ${$i}

Outputs:
Warning: could not find cvar {$i}
Warning: could not find cvar i}

It works correctly in 2.3 on Linux. Didn't get it tested on Windows.
------------------------------------------------

Here's another parsing error WinstonSmith pointed out on IRC:
// blah ; echo "this shouldn't print"

Outputs:
this shouldn't print

There is a workaround for this one:
// "blah ; echo "this shouldn't print""

no output since the ; is within quotes

[divVerent]

Indirection works very fine here. You must be using an old engine build.

set x 1
set i x
echo ${$i}
1

[AceOfThumbs]

I'm using the May 30, 2007 2.3 release for Mac. I don't have Linux, but WinstonSmith on IRC said he tested the 2.3 release on Linux and it worked, but on the 2.4 SVN it didn't.