The last two days I've played a lot of ladder games.. but please someone else than the ones I've been playing also start joining in.. I get my ass kicked here... The last two days I've played:

esteel 59 : 8
Luna 81 : 7
morfar 108 : 14
Xant 55 : 6
Stryku 48 : 25
k0jak 81 : -1

Needless to say I'm not that good ranked any more , so if please, someone with more human skills could join up to Or at least start playing

Remember to check infrom time to time to see if you are challenged!

why don't you just contact other people in the ladder, via PM (or just challenge them) ?

im always ready for a match

GreEn`mArine wrote:why don't you just contact other people in the ladder, via PM (or just challenge them) ?

He has.. ideed he has enough open challanges to be fighting till the next millenium
That reminds me to find some time to ladder matches myself.

cyan you are evil..

Well, now that my hardware's workin well, I'll need another few days to practice the standard DM (hard! I'd need two more hands to battle my minstagib mates and play DM at the same time ) and then You'll get one with human skills.

But it takes some more days, sry!

cyan wrote:im always ready for a match

Hehe.. If i lose onther 9 point I wont be able to challenge anyone, including new players, so I have to be a lil more careful
Edit: Cyan I'v challenged everyone on this side of the atlantic now, so I guss you can just challenge me, since my challenges are open anyways If you wish. Might as just get it over with

tChr wrote:

cyan wrote:im always ready for a match

Hehe.. If i lose onther 9 point I wont be able to challenge anyone, including new players, so I have to be a lil more careful
Edit: Cyan I'v challenged everyone on this side of the atlantic now, so I guss you can just challenge me, since my challenges are open anyways If you wish. Might as just get it over with

well, okay. I'll modify the "allow challenge" function that you will always be able to challenge people who have 1000 points and 0 matches

this is rather easy, because everything I have to do is to modify the code in the table that shows the new players .. instead of having the function decide whether to display the challenge link or not I'll simply always display it (if there are no open challenges of course and if you're logged in)
I can do this because the code that creates the table with the enw players is separated from the code creating the table with the players already having matches

...arg, this won't work, because even if the link is available you'd be blocked by the function then .. I'll incorperate this into the function, that's it

"please wait"

GreEn`mArine wrote:

tChr wrote:

cyan wrote:im always ready for a match

Hehe.. If i lose onther 9 point I wont be able to challenge anyone, including new players, so I have to be a lil more careful
Edit: Cyan I'v challenged everyone on this side of the atlantic now, so I guss you can just challenge me, since my challenges are open anyways If you wish. Might as just get it over with

well, okay. I'll modify the "allow challenge" function that you will always be able to challenge people who have 1000 points and 0 matches

this is rather easy, because everything I have to do is to modify the code in the table that shows the new players .. instead of having the function decide whether to display the challenge link or not I'll simply always display it (if there are no open challenges of course and if you're logged in)
I can do this because the code that creates the table with the enw players is separated from the code creating the table with the players already having matches

From a programming point of view i think this sounds scary, isnt there a test later in the system so see if you are allowwed to challenge too? It fhe only test is in the list, its easy to bypass.

okay, it's in now (I edited the post above).
old function:

Code: Select all

function pointRangeOk ($session_id, $enemy_id)
{
   //get to know whether the user who you want to challenge hasn't more than $pointrange points than you have
   //function will return true if the range is okay
   global $prefix;
   global $conn;
   global $pointrange;
   $own_points = get_playerpoints($session_id);
   $enemy_points = get_playerpoints($enemy_id);
   $point_difference = $enemy_points-$own_points;
   if ($point_difference <= $pointrange)
   {
      return true;
   }
   else {
      return false;
   }
}

new function:

Code: Select all

function pointRangeOk ($session_id, $enemy_id)
{
   //get to know whether the user who you want to challenge hasn't more than $pointrange points than you have
   //function will return true if the range is okay
   global $prefix;
   global $conn;
   global $pointrange;
   $own_points = get_playerpoints($session_id);
   $enemy_points = get_playerpoints($enemy_id);
   $point_difference = $enemy_points-$own_points;
   //allow also a bigger pointrange than $pointrange if the challenged players is new (0 matches, 1000 points)
   $numbsql = "SELECT * FROM `".$prefix."matches` WHERE (challenger_userid='".$enemy_id."' OR challenged_userid='".$enemy_id."') AND match_report_accepted!=0 AND deleted='0'";
   $numbquery = mysql_query($numbsql) or die(mysql_error());
   $matchnumber = mysql_num_rows($numbquery);
   if ($point_difference <= $pointrange || ($enemy_points == 1000 && $matchnumber == 0))
   {
      return true;
   }
   else {
      return false;
   }
}

GreEn`mArine wrote:okay, it's in now (I edited the post above).
old function:

Code: Select all

function pointRangeOk ($session_id, $enemy_id)
{
   //get to know whether the user who you want to challenge hasn't more than $pointrange points than you have
   //function will return true if the range is okay
   global $prefix;
   global $conn;
   global $pointrange;
   $own_points = get_playerpoints($session_id);
   $enemy_points = get_playerpoints($enemy_id);
   $point_difference = $enemy_points-$own_points;
   if ($point_difference <= $pointrange)
   {
      return true;
   }
   else {
      return false;
   }
}

Man you write orderly.. I'd do:

Code: Select all

function pointRangeOk ($session_id, $enemy_id) {
   global £prefix, $conn, $pointrange;
   if ((get_playerpoints($enemy_id) - get_playerpoints($session_id)) <= $pointrange)  return true;
   return false;
}


but your way is better
edit: is $prefix and $conn needed?
edit2: it is in the new functino NM

I'd join in if there were any point in doing so.

kozak6 wrote:I'd join in if there were any point in doing so.

Wy isnt there? There should be at least 3 US servers now.

tChr wrote:

Code: Select all

function pointRangeOk ($session_id, $enemy_id) {
   global £prefix, $conn, $pointrange;
   if ((get_playerpoints($enemy_id) - get_playerpoints($session_id)) <= $pointrange)  return true;
   return false;
}


I see bloat there!
I would suggest:

Code: Select all

function pointRangeOk ($session_id, $enemy_id) {
   global $prefix, $conn, $pointrange;
   return (get_playerpoints($enemy_id) - get_playerpoints($session_id)) <= $pointrange;
}

KadaverJack wrote:

tChr wrote:

Code: Select all

function pointRangeOk ($session_id, $enemy_id) {
   global £prefix, $conn, $pointrange;
   if ((get_playerpoints($enemy_id) - get_playerpoints($session_id)) <= $pointrange)  return true;
   return false;
}


I see bloat there!
I would suggest:

Code: Select all

function pointRangeOk ($session_id, $enemy_id) {
   global $prefix, $conn, $pointrange;
   return (get_playerpoints($enemy_id) - get_playerpoints($session_id)) <= $pointrange;
}

Hmm,.. you're right
allthough:

Code: Select all

function pointRangeOk ($session_id, $enemy_id, $pointrange) {
   return (get_playerpoints($enemy_id) - get_playerpoints($session_id)) <= $pointrange;
}

Is even better
Then again.. why put it in a function.. unless you use it more than one place, that is
Edit: but still Greens way is a bit easier to debug

I know that this if {} else {} thing is actually not needed in the function but I like it anyway ("return xx" would break the function anyway)

as this pointranke function IS used several times (not only for displaying the link but also for checking, whether the user is allowed to see the "Challenge" page, it is the easiest thing to have it in a function and not in every php page

I dont thek anyone means to critizise your code IWe just like to make a mindfuck of about everythign