I've fixed status command. Now it's nicer to see, more readable and it displays the complete names (no more truncated tags).

The patch for this command is needed also to display more chars in names with lots of new color tags that I did. A name like ^xf00t^x0f0e^xf00r^x0f0ence ^4hill without this patch is shown with only 3 chars (a part the horrible truncated tag...): ter^xf0

Download link: http://sites.google.com/site/terencehill/Nexuiz/status.patch

And don't forget, this patch works only in your own server.

I really am not sure whether this can be applied, or whether the output of the "status" command must stay the same to be compatible with other quake engines (some engines issue that command in the background, and parse its output).

However, there is a new command "cmd teamstatus" which shows a more detailed scoreboard than status. Maybe there could be a similar command that doesn't focus on the scores, but on ping and packetloss, and is also some "cmd". It could be aliased to "st" then...

Doesn't dp have own networking protocol?

Yes, but:

1. it also parses "status" replies (for darkplaces_iplog.txt)

2. it does support acting as a Quake server, and people actually do that and connect with other Quake engines to DP. Your status patch currently breaks that.

Maybe it would be possible to differentiate output based on the protocol:
old status if protocol == NQ or QW and new status if protocol == DP. Problems would arise if other engines support DP protocol too and use status to parse info. Same goes for qstat.

probably just creating a new command will be way easier

The problem in the current status command is that is actually unreadable.

You use it when u want to know or the ip of a player, or his number, to kick him or simply to send him a private message.

Therefore the command "cmd teamstatus" is unuseful for this goal.

But I've understood, this patch can't be applied, so I guess the things will stay as they are.

terencehill wrote:But I've understood, this patch can't be applied, so I guess the things will stay as they are.

But there's no reason another command can't be aliased, like 'superstatus'. The concern is just with breaking current systems.

BY prompt of esteel, I've done a patch to the status command to displays in other 2 differents ways the informations on players playing in the current server, as the default way is very chaotic and unreadable. Now it's nicer to see, more readable and it displays the complete names (no more truncated tags).
So now the default command is still available, but if you put after status the number 1 or 2 you have 2 other different layouts.

* status 1 shows an extended layout with many infos,
* status 2 shows a semplified layout with the more importants infos.

Using these 2 new commands, the IPs of players are not stored in the file darkplaces_iplog.txt.

status 0 works in the same way as status.

Screenshot: http://sites.google.com/site/terencehill/Nexuiz/status_v2.jpg

Using parameters other than 0, 1 or 2, or using more parameters, it prints nothing.

The status command is server side so the patch can be tried only in your own server.

Download the patch here: http://sites.google.com/site/terencehill/Nexuiz/status_v2.patch.

Finally, no reason not to implement it. Congrats and thanks.

Hey, I just made a quick reading at your code, here my comments:

Don't you cast hours as integers ?

I'd rather to check in just one place if the argument for status goes out of bounds (>2), if that is the case then you can answer with some default (like plain status or "status 1"). This way the code will be just a little bit cleaner and easier to maintain.

I haven't patched my SVN copy yet, I'll do it later and come back with comments.

Cheers

Don't you cast hours as integers ?

I didn't touch the code to show the time.

I'd rather to check in just one place if the argument for status goes out of bounds (>2), if that is the case then you can answer with some default (like plain status or "status 1"). This way the code will be just a little bit cleaner and easier to maintain.

As i wrote, I've chosen this option: "Using parameters other than 0, 1 or 2, or using more parameters, it prints nothing.", since the previous behavior of status was to print nothing if any argument was given.

That's good already. It sure will go in, as there is indeed no reason against now, and this code shouldn't be breaking anything (I haven't read it yet though, might need some cleaning up).

Now all you need is to do aesthetics... maybe make the colors look better... only such stuff left.

But why does it show an IP for your bots, and not "botclient"? That looks like a bug

BTW, status 1 looks good to parse. Maybe make it look less blinding by the colors (use less colors, that is)... then it could even become a new "standard" among quake engines (that be DP and FTE only, though). It also is fully and simply parsable (nicknames at the end, anything else is easily to find by word splitting).

But why does it show an IP for your bots, and not "botclient"? That looks like a bug Razz

I've changed simply the code during the tests to show an IP instead of botclient.

Maybe make it look less blinding by the colors (use less colors, that is)...

I thought that the better thing was to give a color for each column so that they can be quickly distinguishable and nice to see...

Using less colors, maybe IPs and numbers yellow both, or yellow and green, dunno...
if u want, u can apply the patch and put the colors u like, or remove them all too...

I miss the layout of the 1st post of yours.
[/img]

terencehill wrote:I didn't touch the code to show the time.

Sure, sorry for that, I've read the patch too quickly

As i wrote, I've chosen this option: "Using parameters other than 0, 1 or 2, or using more parameters, it prints nothing.", since the previous behavior of status was to print nothing if any argument was given.

My suggestion was at code level, but then I've patched dp and saw that your approach is very good. And I don't think that we need a new "status 3" in the short term, so maybe any other effort for improving this function is worthless.

It works like a charm here Nice job !!!!

I have one other suggestion for "status 1": can you make it also show packet loss (code for reading that is in the "pings" command)?

Changes:
* List more readable, using alternate colors for the rows
* status 2 now has the same style of status 1
* Added packetloss to status 1

screenshot:
http://sites.google.com/site/terencehill/Nexuiz/status_v3.jpg

patch:
http://sites.google.com/site/terencehill/Nexuiz/status_v3.patch

Yeah, thanks for fixing status 2.

I really like this new display, which is easy on the eyes. I'll apply that patch then.

I did change it a bit though, since "status shjdlhjsdflhjdl" does print the regular status in previous DP svn.

Alien wrote:Yeah, thanks for fixing status 2.

I didn't want to fix status 2 btw...
I wanted that the name was near to the number and the IP, so they can be read quickly once u find the name u were seeking. This was the purpose. But now with alternate colors I've noticed that's almost the same thing, but nicer to see.

divVerent wrote:I did change it a bit though, since "status shjdlhjsdflhjdl" does print the regular status in previous DP svn.

OH man! I was convinced that the old cmd printed nothing with one or more given argument/s... My mistake, sry

Speaking of status, as "status 1" now is fully parsable output, I think I'll make rcon2irc request that status. That way, it can have the full player names and IPs (no idea what for yet, but it may prove useful).

Good job mate!

Code: Select all

<OpBaI> login ***********
<haggerNexCTF> my wish is your command
<OpBaI> status
<haggerNexCTF> 84.58.11.28:26127      0  100  0:08:29 -666 #1   [R9M]div{}Verent [PB] {X} (dev)
<haggerNexCTF> botclient              0    0  0:07:13    0 #2   [Dave]Dominion {X}
<haggerNexCTF> botclient              0    0  0:01:58    0 #3   [Dave]Dominion {X}
<OpBaI> kick # 2 AHAHAHAHAHAHAH))
<haggerNexCTF> kicked 2 ([Dave]Dominion {X} @ botclient) (AHAHAHAHAHAHAH)))
<OpBaI> bans
<haggerNexCTF> 0 (194.187.59.90, 64.400002s), 1 (82.135.221, 64.400002s), 2 (82.135.221.82, 64.400002s)
<OpBaI> kickban # 1 86400 3 IRC testing AHAHAHAHAH))
<haggerNexCTF> kickbanned 1 ([R9M]div{}Verent [PB] {X} (dev) @ 84.58.11.28:26127), netmask 3, for 86400 seconds (IRC testing AHAHAHAHAH)))
<OpBaI> bans
<haggerNexCTF> 0 (194.187.59.90, 152.800003s), 1 (82.135.221, 32.800003s), 2 (82.135.221.82, 152.800003s), 3 (84.58.11, 86383.546875s)
<OpBaI> unban 3
<haggerNexCTF> removed ban #3 (84.58.11)
<OpBaI> aaa
<haggerNexCTF> unknown command (supported: status [substring], kick # id reason, kickban # id bantime mask reason, bans, unban banid)


With the "status 1" format, this was very easy.

OMG COOLEST!

hm... was this done in pm-ing the bot on irc?

yes

I'm finding a limit of 15 or 16 with "status 1" even when "status" or "status 2" show 22 players. Frags also returns 0 for CTF.



Note: every 1 out of ~10 tries, I get 22 names from "status 1"

The frags only showing 0/-666 is because the whole scorekeeping is now done in QC and setting the frags for the engine too would needlessly increase the bandwidth used by Nexuiz. If you want to see the frags use 'teamstatus'

[-z-]: Update your rcon2irc, this has been fixed in rcon2irc. You may want to increase the timeout for packet reading (rcon_timeout_inter=0.5 for example) if it still doesn't work reliably enough.

As for frags showing 0 and -666, this can't REALLY be helped... not sure if status should always be showing cl->frags. I can make the code show the "qcstatus" column instead, but then the column width would depend on the mod.

Then I think frags should be changed to playing or spectating depending on the value.